Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multiple-value uuid.NewV4() in single-value context #166

Merged
merged 9 commits into from
May 24, 2018
Merged

Fix multiple-value uuid.NewV4() in single-value context #166

merged 9 commits into from
May 24, 2018

Conversation

sulthonzh
Copy link
Contributor

Fix multiple-value uuid.NewV4() in single-value context

@sulthonzh
Fix : multiple-value uuid.NewV4() in single-value context
5be0053 
Fix : multiple-value uuid.NewV4() in single-value context
For example :

Old :
model.ID = uuid.NewV4()
Fix:
model.ID, _ = uuid.NewV4()
@sulthonzh
Fix : undefined: doc.IsPredeclared
bc1fb28 
# golang.org/x/tools/godoc
src/golang.org/x/tools/godoc/linkify.go:186: undefined: doc.IsPredeclared
@sulthonzh
Update goadesign/gorma go version
991970a
@sulthonzh
Update .travis.yml
4a7a99f
@sulthonzh
Restore to old
d77efec
@sulthonzh
Restore Original
d0244b7
@raphael
Copy link
Member

raphael commented May 22, 2018

Thank you! a couple of things I noticed:

  • Please update the .travis.yml file so that the deploy triggers on 1.10.x instead of 1.8.1 (it would never trigger otherwise)
  • Please change the code so that instead of generating model.ID, _ = uuid.NewV4() it generates model.ID = uuid.Must(uuid.NewV4()) to maintain the same behavior.

sulthonzh added 2 commits May 23, 2018 07:29
@sulthonzh
Fix UUID
fc79c69 
.ID, _ = uuid.NewV4() -> ID = uuid.Must(uuid.NewV4())
@sulthonzh
Upgrade go env
6191fee 
Upgrade go env
@raphael
Copy link
Member

raphael commented May 24, 2018

I think 6191fee#diff-354f30a63fb0907d4ad57269548329e3R34 needs to be 1.10.x or at least 1.10.2 since that's the last Go version and what 1.10.x will target when Travis builds.

@raphael raphael mentioned this pull request May 24, 2018
Closed
@sulthonzh
Upgrade go env
9debd09 
1.10.1 -> 1.10.2
@raphael
Copy link
Member

raphael commented May 24, 2018

Great, thank you!

@raphael raphael merged commit d446c42 into goadesign:master May 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sulthonzh @raphael